Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI badge in README #974

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Fix CI badge in README #974

merged 1 commit into from
Mar 17, 2021

Conversation

slonopotamus
Copy link
Contributor

@slonopotamus slonopotamus commented Mar 17, 2021 •
edited
Loading

This is a follow-up to #970

Looks like I used wrong image URL, so it gives 404. Unfortunately, this was not possible to test until GitHub Actions started working for microsoft/hcsshim repo. Sorry for inconvenience.

@slonopotamus slonopotamus requested a review from a team as a code owner March 17, 2021 18:33
@slonopotamus
Fix CI badge in README
282a503 
This is a follow-up to microsoft#970
@slonopotamus
Copy link
Contributor Author

Now, you can see in my branch for current PR that badge image displays properly if this PR is applied.

katiewasnothere
katiewasnothere approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you 🙂

@katiewasnothere katiewasnothere merged commit 9e1ba4d into microsoft:master Mar 17, 2021
@slonopotamus slonopotamus deleted the patch-1 branch March 17, 2021 18:43
anmaxvl pushed a commit to anmaxvl/hcsshim that referenced this pull request Aug 19, 2021
@katiewasnothere
Merged PR 4370459: Update ADO to github commit d9474d2
ed39d07 
This PR updates our internal ADO repo to the github commit [d9474d2](microsoft@d9474d2).

Related work items: microsoft#964, microsoft#965, microsoft#966, microsoft#967, microsoft#968, microsoft#969, microsoft#970, microsoft#971, microsoft#972, microsoft#974, microsoft#975, microsoft#976, microsoft#977, microsoft#978, microsoft#979, microsoft#980, microsoft#981, microsoft#982, microsoft#983, microsoft#984, microsoft#987, microsoft#990, microsoft#991, microsoft#992, microsoft#993, microsoft#995, microsoft#996, microsoft#997, microsoft#1000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katiewasnothere katiewasnothere katiewasnothere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slonopotamus @katiewasnothere